Opened 3 weeks ago

Last modified 13 days ago

#5865 assigned defect

Refactoring static fields

Reported by: jwedin Owned by: jwedin
Priority: major Milestone:
Component: Modelica/FrontEnd Version: trunk
Keywords: Cc:

Description


Change History (14)

comment:1 Changed 3 weeks ago by jwedin

Changed so that node count dumping is done on the root node instead of statically on ASTNode. Refactored some fields to no longer be static. Changed so that DSSets are given their id in the constructor. r13900

comment:2 Changed 3 weeks ago by jwedin

Moved the unitTempMap to UtilInterface. Updated the comment about the temp names accumulating over all tests since this does not seem to be accurate anymore. r13914

comment:3 Changed 3 weeks ago by jwedin

GenericAnnotationNodes can now be immutable. Changed so static singleton annotations are immutable. Added and updated Javadoc for some annotation node classes. Updated the state in GenericAnnotationNode to no longer be volatile. r13921

comment:4 Changed 3 weeks ago by jwedin

Minor fix. r13923

comment:5 Changed 3 weeks ago by jwedin

Fixed a problem related to Java 7 compliance. Removed redundant lines of code. r13926

comment:6 Changed 3 weeks ago by jwedin

Restored the behavior for mutable annotation nodes. Changed so that public methods on GenericAnnotationNode does not cause state modifications on immutable nodes. An exception to this is the setValue method which will throw an UnsupportedOperationException if the node is immutable. Removed some unnecessary mutability checks in private methods. r13936

comment:7 Changed 2 weeks ago by jwedin

Changed so the template sets no longer are static. The memberSets field of the HomotopyContributor is now unmodifiable. r13960

comment:8 Changed 2 weeks ago by jwedin

Moved buildNodeCountMap from ASTNode to UtilInterface. r13967

comment:9 Changed 2 weeks ago by jwedin

Moved the buildNodeCountMap implementation to Profiling.jrag. Changed so Counter is no longer an inner class on ASTNode. Renamed Counter to ASTNodeCounter. r13986

comment:10 Changed 2 weeks ago by jwedin

Changed GenericAnnotationNode to handle its state with a new state manager object. The state manager supports immutability which is used for ambiguous nodes. r13992

comment:11 Changed 13 days ago by jwedin

Minor fix. r13993

comment:12 Changed 13 days ago by jwedin

Removed the unused interface NodeCountExtra. Updated the documentation for the node count functionality. r13998

comment:13 Changed 13 days ago by jwedin

Updated annotation node constructors. Removed redundant calls to isAmbiguous in the mutable state manager. Removed unnecessary state for ambiguous nodes. r14001

comment:14 Changed 13 days ago by jwedin

Merging dev-jw-2590 to trunk. r14002

Note: See TracTickets for help on using tickets.