Opened 7 months ago

Last modified 6 months ago

#5755 new enhancement

Change the platforms commandline argument to an option

Reported by: Zimon Kuhs Owned by: Jesper Mattsson
Priority: minor Milestone:
Component: General Version: trunk
Keywords: platforms, command-line, option Cc:

Description

The platforms argument used when compiling from command-line should be converted to an option, as it functionally behaves as one and defaults to the system architecture's platform if not set.
Also, since only Windows 32/64 and Linux 64 are functionally supported, the command-line parameter "platforms" should be restricted.

Change History (8)

comment:1 Changed 7 months ago by Zimon Kuhs

r12630

Changed the command-line argument to a compiler option.
Also did some light refactoring.

comment:2 Changed 7 months ago by Zimon Kuhs

r12634

Removed platform arguments from _gen_compiler_options that were left in due to refactoring.
Updated usages of "platform" to the correct option name "platforms".

comment:3 Changed 7 months ago by Zimon Kuhs

r12637

Changed the "platforms"-option to use "win" instead of "windows" as possible values.

Also fixed bugs:

  • Null-pointer when "-opts" wasn't set from command line, due to wrong name when setting up options.
  • Wrong argument order in pymodelica's compilation method.

comment:4 Changed 7 months ago by Zimon Kuhs

r12647

Fixed bug introduced by r12637.

Last edited 7 months ago by Zimon Kuhs (previous) (diff)

comment:5 Changed 7 months ago by Zimon Kuhs

r12711

Fixed getPlatforms() and added usage of it when setting targets for the C compiler.

comment:6 Changed 6 months ago by Zimon Kuhs

r12798

Catchup merge from trunk.

comment:7 Changed 6 months ago by Zimon Kuhs

r12808

  • Changed back option to be named target_platforms and only allow singular strings. Logic can still handle lists if necessary in the future.
  • Fixed bug that caused platform to always be set to the default for the current platform.

comment:8 Changed 6 months ago by Zimon Kuhs

r12813

  • Removed -platform from separate process.
  • Added "" as an allowed option value.
Note: See TracTickets for help on using tickets.