Opened 3 years ago

Last modified 3 years ago

#5284 reopened defect

Update Jastadd to 2.2.*

Reported by: Zimon Kuhs Owned by: Jesper Mattsson
Priority: major Milestone:
Component: Modelica/FrontEnd Version: trunk
Keywords: Cc:

Description

This requires updating build-base.xml's jastadd task with a flag, as well as some cleanup:

  • Update double NTA-declarations (when NTA is declare for an attribute both in the AST and a .jrag file).
  • Modification of the if-equation elimination to not use list rewrites.

Change History (11)

comment:1 Changed 3 years ago by Zimon Kuhs

changeset:9609

Updated JastAdd to version 2.2.2.

Some changes were required:

  • Flag in build-base.
  • Iterator implementation for ASTNode.
  • Removal of two equations and a package declaration.
  • Removing use of the field 'child' in a lookup equation.

comment:2 Changed 3 years ago by Zimon Kuhs

changeset:9610

Removed unnecessary NTA declarations from equations.

comment:3 Changed 3 years ago by Zimon Kuhs

changeset:9620

Added the 'lazy' attribute to the equations that had 'nta' removed in r9610.

comment:4 Changed 3 years ago by Zimon Kuhs

changeset:9625

Fixed a lookup issue introduced in r9609.

comment:5 Changed 3 years ago by Zimon Kuhs

changeset:9628

Removed all list rewrites.

Removed most of the standard list rewrites in if-equation elimination and rewrite as well.

comment:6 Changed 3 years ago by Zimon Kuhs

changeset:9632

Bugfix for r9628 (nested branches were not eliminated properly).

comment:7 Changed 3 years ago by Zimon Kuhs

Resolution: fixed
Status: newclosed

comment:8 Changed 3 years ago by Zimon Kuhs

Resolution: fixed
Status: closedreopened

Reopening ticket due to update from JastAdd team. Build time should now be reasonable without the --inhEqCheck=false flag.

comment:9 Changed 3 years ago by Zimon Kuhs

Resolution: fixed
Status: reopenedclosed

changeset:9674

Updated JastAdd2 to the latest version due to recent fixes in 2.2.2.

This improves build time greatly (roughly 30% faster, back to before the update to 2.2.*).

This also exposes a bug regarding the NTA FunctionType in InstClassDecl for InstPartialFunctionCall. Added a workaround for the moment.

comment:10 Changed 3 years ago by Jonathan Kämpe

Resolution: fixed
Status: closedreopened

comment:11 Changed 3 years ago by Jonathan Kämpe

changeset:9678

Reverting r9674 since it broke some tests

Note: See TracTickets for help on using tickets.