Opened 4 years ago

Closed 2 years ago

#4420 closed enhancement (fixed)

Constant propagation of noEvent

Reported by: Christian Andersson Owned by: Jonathan Kämpe
Priority: major Milestone: Pending
Component: Modelica/FrontEnd Version: trunk
Keywords: #4093. Cc:

Description

In the model Modelica.Fluid.Examples.Tanks.EmptyTanks there are constants surrounded by noEvent clauses, i.e.:

BLT for DAE system
ODE blocks 
...
--- Solved equation ---
pipe.flowModel.rhos_act[1] := noEvent(995.586)
--- Solved equation ---
pipe.flowModel.mus_act[1] := noEvent(0.001)

These should be simplified and set to constants.

This is a part of #4093.

Change History (5)

comment:1 Changed 4 years ago by Christian Andersson

Additionally, in cases like noEvent(x), the noEventoperator should be removed.

Last edited 4 years ago by Christian Andersson (previous) (diff)

comment:2 Changed 4 years ago by jsten

Normally this should be handled by variabilitypropagation, but in this case it hits the same bug as #3989.

comment:3 Changed 4 years ago by Jonathan Kämpe

Milestone: 1.17.xPending

comment:4 Changed 3 years ago by Christian Andersson

changeset:9072

Fixed symbolic simplifications of smooth and noevent for expressions of type noEvent(x) and smooth(0, x). Related to ticket:4476 and ticket:4420

comment:5 Changed 2 years ago by Christian Andersson

Resolution: fixed
Status: newclosed

This has been fixed as of changeset:9072

Note: See TracTickets for help on using tickets.