Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#4411 closed defect (fixed)

Check for immediate solution in enhanced fixed point iteration

Reported by: efredriksson Owned by: efredriksson
Priority: major Milestone: Pending
Component: FMU/JMU runtime Version: trunk
Keywords: Cc:

Description (last modified by efredriksson)

There is a (small) possibility that a consistent solution is found immediately when entering enhanced fixed point iteration that was not found in the fixed point iteration. A check should be added in the beginning of the enhanced fixed point iteration to avoid this.

Observed in Tanks.TanksWithOverflow.

Attachments (1)

enhanced_fixed_point_iteration_fix.patch (3.1 KB) - added by efredriksson 4 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 4 years ago by efredriksson

Milestone: 1.16.x1.17.x

comment:2 Changed 4 years ago by efredriksson

It seems that Tanks.TanksWithOverflow now works without this. As for now i don't see this happening unless the warning ToManyEventIterations was first triggered or something similar but the extra first iteration from the enhanced iteration gives convergence. I have attached a patch with suggested solution.

Observe that this is very hard to test.

Changed 4 years ago by efredriksson

comment:3 Changed 4 years ago by efredriksson

Keywords: #4391. removed

comment:4 Changed 4 years ago by efredriksson

Description: modified (diff)

comment:5 Changed 4 years ago by Tove Bergdahl

Milestone: 1.17Pending

comment:6 Changed 3 years ago by Christian Andersson

changeset:9155

Applied patch for checking if there is a solution directly when entering the enhanced event iteration. Related to ticket:4411

comment:7 Changed 3 years ago by Christian Andersson

changeset:9157

Fixed while statement, wrong condition from changeset:9155, related to ticket:4411

comment:8 Changed 3 years ago by Christian Andersson

changeset:9161

Merged changes made in branch to trunk. Related to ticket:4411

comment:9 Changed 3 years ago by Christian Andersson

changeset:9162

Added test for immediate solution when starting enhanced event iteration. Related to ticket:4411

comment:10 Changed 3 years ago by Christian Andersson

Resolution: fixed
Status: newclosed

comment:11 Changed 3 years ago by aramle

r9336 Added missing log type.

Note: See TracTickets for help on using tickets.