Opened 5 years ago

Closed 4 years ago

#3879 closed defect (fixed)

Add check for a solution when calculating the minimum norm sol

Reported by: Christian Andersson Owned by: Christian Andersson
Priority: major Milestone: Future
Component: FMU/JMU runtime Version: trunk
Keywords: Cc:

Description

Currently when a singular Jacobian is detected in our linear solver, a minimum norm solution is directly calculated. However, there is no check performed that actually checks if the calculated solution is a solution to the linear system or not. This needs to be added.

Attachments (2)

linear_solution_check.patch (7.6 KB) - added by Christian Andersson 5 years ago.
linear_solution_check_v2.patch (7.6 KB) - added by Christian Andersson 5 years ago.

Download all attachments as: .zip

Change History (10)

Changed 5 years ago by Christian Andersson

Attachment: linear_solution_check.patch added

Changed 5 years ago by Christian Andersson

comment:1 Changed 5 years ago by Christian Andersson

Milestone: 1.15.x1.16.x

comment:2 Changed 4 years ago by Christian Andersson

Milestone: 1.16.x1.17.x

comment:3 Changed 4 years ago by Christian Andersson

Milestone: 1.17Future

comment:4 Changed 4 years ago by aramle

r8512:
#3879 Added a check for a valid minimum norm solution in case of a singular Jacobian.
#4475 In case we have an entire row in the Jacobian equal to 0, use heuristic residual scaling instead of the maximum.

comment:5 Changed 4 years ago by aramle

r8512 #3879 Deleted unused variable missed in commit r8512.

comment:6 Changed 4 years ago by aramle

r8516 #3879 Fixed test issue and added kin_char_log for logging update of scaling in log.

comment:7 Changed 4 years ago by aramle

r8518 Added logging of tolerance to no valid minimum norm solution error message.

comment:8 Changed 4 years ago by aramle

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.