Opened 7 years ago

Closed 22 months ago

#2574 closed defect (fixed)

Newton solver exit clean even if there are errors in the function evaluations

Reported by: jakesson Owned by: Iakov Nakhimovski
Priority: major Milestone: Pending
Component: FMI/Export Version: trunk
Keywords: Cc:

Description (last modified by Iakov Nakhimovski)

In some situations, when there are errors in the function evaluations, e.g., NaNs, the solver exit cleanly, which is incorrect.

Revisit after #2418 is fixed.

Change History (13)

comment:1 Changed 7 years ago by jakesson

changset:4404:

Fixed a bug that rendered the Newton solvers to exit clean even if there are errors in the residual values, see #2574.

Need review.

comment:2 Changed 7 years ago by jakesson

changeset:4405:

Made a minor update to r4404, see #2574.

comment:3 Changed 7 years ago by jakesson

changeset:4408:

Made a minor update to r4404, see #2574.

comment:4 Changed 7 years ago by jakesson

changeset:4416:

Reinserted the converged test when Kinsol returns in order to capture the case when there is an error exit flag but the residuals indicate convergence. This check is done now only for the exitflag: KIN_LINESEARCH_NONCONV. With this commit errors in function evaluations should still result in an error being returned from Kinsol. See #2574.

comment:5 Changed 6 years ago by jakesson

Owner: set to Iakov Nakhimovski
Status: newassigned

comment:6 Changed 6 years ago by Tove Bergdahl

Milestone: 1.10.x1.10

comment:7 Changed 6 years ago by Iakov Nakhimovski

r4954:

Added a test that exception is thrown if dae block returns NAN and no solution found. See #2574

comment:8 Changed 6 years ago by Iakov Nakhimovski

r4961:

Fixed a bug in test Modelica model. See #2574

comment:9 Changed 6 years ago by Iakov Nakhimovski

Milestone: 1.101.11.x

Made a code review, some clean up and comments in the block solvers. There are some possible issues with error propagation from linear block solver. Those however should be easy to notice. No currently failing tests found. Keep this open to come back after restructuring of block solver codes.

comment:10 Changed 6 years ago by Iakov Nakhimovski

r4978:

Made a code review, some clean up and comments in the block solvers. See comment above.

comment:11 Changed 6 years ago by Iakov Nakhimovski

Description: modified (diff)
Milestone: 1.11.x1.12.x

comment:12 Changed 6 years ago by Tove Bergdahl

Milestone: 1.12.xPending

comment:13 Changed 22 months ago by Jesper Mattsson

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.